Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error "No sentinels available" when the master name is different from the host name #534

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nguyenductung
Copy link

Associated with issue #531.
This allows master_name in options.

@stephankaag
Copy link

Anyone?

1 similar comment
@nguyenductung
Copy link
Author

Anyone?

@stephankaag
Copy link

CC @djanowski

@jperville
Copy link

+1

@djanowski
Copy link
Collaborator

Needs tests.

@plribeiro3000
Copy link

@nguyenductung I need this change. Would you be able to add tests for it?
Otherwise i can open a new pull request.

Thanks!

not-a-robot bot added a commit that referenced this pull request Jul 17, 2017
640: Add new master_name param for sentinel. Fixes #531 r=badboy

Associated with issue #531.
Based on #534 with the addition of tests.
Didn't know how to keep @nguyenductung 's commit sadly but this PR does fix the issue and is tested.


701: Get tests passing with frozen-string-literals enabled. r=badboy

This one simple change ensure that all string literals can be frozen (as per the optional feature in MRI 2.3 and onwards). @twalpole has (again) beaten me to such a patch (in #590), though mine (again) does not add the pragma comment to all files. Getting their or my PRs merged in would be excellent :)

As an alternative to the pragma comment, I would recommend adding the following to your .travis.yml file to ensure regressions aren't introduced:

```yml
before_script:
- if (ruby -e "exit RUBY_VERSION.to_f >= 2.4"); then export RUBYOPT="--enable-frozen-string-literal"; fi; echo $RUBYOPT
```

This will add the flag when the tests are run on MRI 2.4 or newer (while the feature was introduced in 2.3, it doesn't seem to work reliably until 2.4). Please note: tests will currently fail when this flag is set unless test-unit is also updated (as noted in test-unit/test-unit#149).
@byroot byroot force-pushed the master branch 6 times, most recently from efe158b to dd4b6fe Compare June 9, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants